lkml.org 
[lkml]   [2015]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 14/42] perf record: Add --index option for building index table
On Mon, Feb 02, 2015 at 02:07:27PM +0200, Adrian Hunter wrote:

SNIP

> >>
> >> Why not make it the same as all the other data. i.e. find the start and size
> >> via the index? And then just lump all the data together?
> >
> > thats what I suggested
>
> No, I meant really lump it all together. i.e. perf_file_header.data.size =
> total data size
>
> >
> >>
> >>> I guess we could workaround that by storing the 'perf_file_header::data'
> >>> as the last data section. That would require to treat it the same way as
> >>> all other data sections, but we could keep current header layout.
> >>
> >> Would it need to be last? Logically it should precede the data that depends
> >> on it.
> >
> > i suggested this as a workaround for having features at the end of the file
> > while keeping the current perf data header
>
> Which wouldn't be necessary if you lump it all together?

yep, that's also an option

jirka


\
 
 \ /
  Last update: 2015-02-02 13:21    [W:0.306 / U:0.364 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site