lkml.org 
[lkml]   [2015]   [Feb]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/3] hv: hv_util: move vmbus_open() to a later place


    On Mon, Feb 2, 2015 at 12:35 PM, Dexuan Cui <decui@microsoft.com> wrote:
    > Before the line vmbus_open() returns, srv->util_cb can be already
    > running
    > and the variables, like util_fw_version, are needed by the
    > srv->util_cb.

    A questions is why we do this for util only? Can callbacks of other
    devices be called before vmbus_open() returns?

    >
    > So we have to make sure the variables are initialized before the
    > vmbus_open().
    >
    > CC: "K. Y. Srinivasan" <kys@microsoft.com>
    > Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
    > Signed-off-by: Dexuan Cui <decui@microsoft.com>
    > ---
    >
    > v2:
    > This is a RESEND.
    > I just added Vitaly's Reviewed-by.
    >
    > drivers/hv/hv_util.c | 11 ++++++-----
    > 1 file changed, 6 insertions(+), 5 deletions(-)
    >
    > diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c
    > index 3b9c9ef..c5be773 100644
    > --- a/drivers/hv/hv_util.c
    > +++ b/drivers/hv/hv_util.c
    > @@ -340,12 +340,8 @@ static int util_probe(struct hv_device *dev,
    >
    > set_channel_read_state(dev->channel, false);
    >
    > - ret = vmbus_open(dev->channel, 4 * PAGE_SIZE, 4 * PAGE_SIZE, NULL,
    > 0,
    > - srv->util_cb, dev->channel);
    > - if (ret)
    > - goto error;
    > -
    > hv_set_drvdata(dev, srv);
    > +

    This seems unnecessary.
    >
    > /*
    > * Based on the host; initialize the framework and
    > * service version numbers we will negotiate.
    > @@ -365,6 +361,11 @@ static int util_probe(struct hv_device *dev,
    > hb_srv_version = HB_VERSION;
    > }
    >
    > + ret = vmbus_open(dev->channel, 4 * PAGE_SIZE, 4 * PAGE_SIZE, NULL,
    > 0,
    > + srv->util_cb, dev->channel);
    > + if (ret)
    > + goto error;
    > +
    > return 0;
    >
    > error:
    > --
    > 1.9.1
    >



    \
     
     \ /
      Last update: 2015-02-02 10:41    [W:4.105 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site