Messages in this thread | | | From | Arseny Solokha <> | Subject | Re: [PATCH 4/4] powerpc/mpic: remove unused functions | Date | Fri, 20 Feb 2015 11:40:33 +0700 |
| |
> If I just get a patch saying "removed unused foo()", I have to go and dig and > find out: > - was it recently added and will be used soon? > - is it ancient and never used, if so can we work out why, ie. feature X > never landed so this code is no longer needed. > - is it old code that *was* used but isn't now because commit ... removed the > last user. > - is it code that *should* be used, but isn't for some odd reason? > > > So if you can provide that sort of detail for me, that really adds value to the > patch. Otherwise the patch is basically just a TODO for me, to go and work out > why the code is unused.
Got it. Will resend the whole series one of these days.
Arsény
> cheers
| |