lkml.org 
[lkml]   [2015]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 5/6] ASoC: samsung: Extend Snow driver to support max98089
On Wed, Feb 18, 2015 at 07:25:58PM +0100, Andreas Färber wrote:

> static const struct of_device_id snow_of_match[] = {
> + { .compatible = "google,snow-audio-max98089", },
> { .compatible = "google,snow-audio-max98090", },
> { .compatible = "google,snow-audio-max98091", },
> { .compatible = "google,snow-audio-max98095", },

Since we completely ignore the CODEC in the property might it not be
better to just add a plain old snow-audio compatible and bind to that,
that way we don't need these driver updates? Just the "snow" bit should
be enough to know it's one of this class of machines.
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-02-19 11:01    [W:0.169 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site