lkml.org 
[lkml]   [2015]   [Feb]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/4] locks: flock and lease related bugfixes, and remove i_flctx counters
On Tue, 17 Feb 2015 20:20:49 +0000
Al Viro <viro@ZenIV.linux.org.uk> wrote:

> On Tue, Feb 17, 2015 at 11:55:01AM -0800, Linus Torvalds wrote:
>
> > Can we get that truncated series tested with some flock test suite? I
> > assume there is *some* filesystem tester that tests some basic flock
> > stuff, even if it clearly didn't catch the race due to the unlock in
> > the middle..
>
> LTP runltp -f syscalls does cover some of that; BTW, looks like fcntl11,
> fcntl11_64, fcntl21 and fcntl21_64 in there got broken by something already
> merged. Hadn't don bisect yet, but seeing
> * NAME
> * fcntl11.c
> *
> * DESCRIPTION
> * Testcase to check locking of regions of a file
> *
> * ALGORITHM
> * Test changing lock sections around a write lock
> and
> * NAME
> * fcntl21.c
> *
> * DESCRIPTION
> * Check locking of regions of a file
> *
> * ALGORITHM
> * Test changing lock sections around a read lock
>
> I'd say that file locking merge is most likely suspect...

Almost certainly. I'll take a look.

Thanks,
--
Jeff Layton <jeff.layton@primarydata.com>


\
 
 \ /
  Last update: 2015-02-17 22:21    [W:0.041 / U:0.716 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site