lkml.org 
[lkml]   [2015]   [Feb]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 143/152] netfilter: ipset: small potential read beyond the end of buffer
    3.2.67-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 2196937e12b1b4ba139806d132647e1651d655df upstream.

    We could be reading 8 bytes into a 4 byte buffer here. It seems
    harmless but adding a check is the right thing to do and it silences a
    static checker warning.

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>
    Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    net/netfilter/ipset/ip_set_core.c | 6 ++++++
    1 file changed, 6 insertions(+)

    --- a/net/netfilter/ipset/ip_set_core.c
    +++ b/net/netfilter/ipset/ip_set_core.c
    @@ -1615,6 +1615,12 @@ ip_set_sockfn_get(struct sock *sk, int o
    if (*op < IP_SET_OP_VERSION) {
    /* Check the version at the beginning of operations */
    struct ip_set_req_version *req_version = data;
    +
    + if (*len < sizeof(struct ip_set_req_version)) {
    + ret = -EINVAL;
    + goto done;
    + }
    +
    if (req_version->version != IPSET_PROTOCOL) {
    ret = -EPROTO;
    goto done;


    \
     
     \ /
      Last update: 2015-02-17 04:01    [W:4.269 / U:0.136 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site