lkml.org 
[lkml]   [2015]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs
On Fri, 4 Dec 2015, David Vrabel wrote:
> On 04/12/15 14:06, David Vrabel wrote:
> > On 03/12/15 10:43, David Vrabel wrote:
> >> Adding the rtc platform device when there are no legacy irqs (no
> >> legacy PIC) causes a conflict with other devices that end up using the
> >> same irq number.
> >
> > An alternative is to remove the rtc_cmos platform device in Xen PV
> > guests.
> >
> > Any preference on how this regression should be fixed?
> >
> > David
> >
> > 8<--------------------------
> > x86: Xen PV guests don't have the rtc_cmos platform device
> >
> [...]
> > --- a/arch/x86/kernel/rtc.c
> > +++ b/arch/x86/kernel/rtc.c
> > @@ -200,6 +200,9 @@ static __init int add_rtc_cmos(void)
> > }
> > #endif
> >
> > + if (xen_pv_domain())
> > + return -ENODEV;
> > +
>
> Note there's a missing include that breaks !XEN builds.

What's the state of this?


\
 
 \ /
  Last update: 2015-12-08 22:21    [W:0.094 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site