Messages in this thread | | | Subject | Re: [PATCH 3/3] clk: tegra-super: Fix sparse warnings for functions not declared as static | From | Rhyland Klein <> | Date | Mon, 7 Dec 2015 12:51:17 -0500 |
| |
On 12/7/2015 10:51 AM, Rhyland Klein wrote: > On 12/4/2015 12:04 PM, Jon Hunter wrote: >> Sparse reports the following warnings for structures and functions that >> should be declared static: >> >> drivers/clk/tegra/clk-tegra-super-gen4.c:70:35: warning: symbol >> 'tegra_super_gen_info_gen4' was not declared. Should it be static? >> drivers/clk/tegra/clk-tegra-super-gen4.c:96:35: warning: symbol >> 'tegra_super_gen_info_gen5' was not declared. Should it be static? >> drivers/clk/tegra/clk-tegra-super-gen4.c:174:13: warning: symbol >> 'tegra_super_clk_init' was not declared. Should it be static? >> >> Fix this by making the above static. >> >> Fixes: 88467d220119 ("clk: tegra: Add Super Gen5 Logic") >> >> Signed-off-by: Jon Hunter <jonathanh@nvidia.com> >> --- >> drivers/clk/tegra/clk-tegra-super-gen4.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) > ... > > Acked-by: Rhyland Klein <rklein@nvidia.com> >
Actually, Don't you need to change the function declarations in drivers/clk/tegra/clk.h for tegra_super_clk_gen[4|5]_init otherwise you will get mismatches with one being declared static and the other not?
-rhyland
-- nvpublic
| |