lkml.org 
[lkml]   [2015]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr is zero

* Rusty Russell <rusty@rustcorp.com.au> wrote:

> Ingo Molnar <mingo@kernel.org> writes:
> > * Rusty Russell <rusty@rustcorp.com.au> wrote:
> >> I don't think there are great answers here. But adding more subtle zeroing
> >> semantics feels wrong, even if it will mostly Just Work.
> >
> > It's not subtle if the naming clearly reflects it (hence my suggestion to rename
> > the API) - and the status quo for on-stack allocations is zeroing anyway, so it's
> > not a big jump...
>
> True, but we already have zalloc_cpumask_var() though if we want that?

Indeed, didn't realize that.

> It probably makes sense to just switch everyone to that and get rid of the non-z
> one?

Yeah, I think this long-lived bug is a proper trigger for that. Lemme send a
2-patch series.

Thanks,

Ingo


\
 
 \ /
  Last update: 2015-12-07 09:41    [W:0.041 / U:1.280 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site