Messages in this thread | | | Date | Mon, 7 Dec 2015 09:23:42 +0100 | From | Ingo Molnar <> | Subject | Re: [RFC][PATCH] Add __GFP_ZERO to alloc_cpumask_var_node() if ptr is zero |
| |
* Rusty Russell <rusty@rustcorp.com.au> wrote:
> Ingo Molnar <mingo@kernel.org> writes: > > * Rusty Russell <rusty@rustcorp.com.au> wrote: > >> I don't think there are great answers here. But adding more subtle zeroing > >> semantics feels wrong, even if it will mostly Just Work. > > > > It's not subtle if the naming clearly reflects it (hence my suggestion to rename > > the API) - and the status quo for on-stack allocations is zeroing anyway, so it's > > not a big jump... > > True, but we already have zalloc_cpumask_var() though if we want that?
Indeed, didn't realize that.
> It probably makes sense to just switch everyone to that and get rid of the non-z > one?
Yeah, I think this long-lived bug is a proper trigger for that. Lemme send a 2-patch series.
Thanks,
Ingo
| |