lkml.org 
[lkml]   [2015]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] usb: host: iounmap before return
From
Date
Hello.

On 12/07/2015 12:30 PM, Lu Baolu wrote:

>> This patch fixes a 'quirk_usb_handoff_xhci()' branch return that was not unmapping correctly.
>>
>> Coccinelle: scripts/coccinelle/free/iounmap.cocci
>>
>> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
>> ---
>> drivers/usb/host/pci-quirks.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
>> index f940056..64150dd 100644
>> --- a/drivers/usb/host/pci-quirks.c
>> +++ b/drivers/usb/host/pci-quirks.c
>> @@ -990,7 +990,7 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev)
>> /* We're reading garbage from the controller */
>> dev_warn(&pdev->dev,
>> "xHCI controller failing to respond");
>> - return;
>> + goto out;
>
> If "out" is only used here, why not iounmap and return directly here?

Why repeat the code? Nah, bad idea.

>> }
>>
>> if (!ext_cap_offset)
>> @@ -1062,6 +1062,7 @@ hc_init:
>> XHCI_MAX_HALT_USEC, val);
>> }
>>
>> +out:
>> iounmap(base);
>> }
>>

MBR, Sergei



\
 
 \ /
  Last update: 2015-12-07 13:01    [W:0.045 / U:0.860 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site