lkml.org 
[lkml]   [2015]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v5 3/4] arm64: mm: support ARCH_MMAP_RND_BITS.
Date
On Monday 07 December 2015 10:26:16 Jon Hunter wrote:
>
> diff --git a/arch/arm64/mm/mmap.c b/arch/arm64/mm/mmap.c
> index af461b935137..e59a75a308bc 100644
> --- a/arch/arm64/mm/mmap.c
> +++ b/arch/arm64/mm/mmap.c
> @@ -51,7 +51,7 @@ unsigned long arch_mmap_rnd(void)
> {
> unsigned long rnd;
>
> -ifdef CONFIG_COMPAT
> +#ifdef CONFIG_COMPAT
> if (test_thread_flag(TIF_32BIT))
> rnd = (unsigned long)get_random_int() % (1 << mmap_rnd_compat_bits);
> else
>
> Cheers
>

Ideally we'd remove the #ifdef around the mmap_rnd_compat_bits declaration
and change this code to use

if (IS_ENABLED(CONFIG_COMPAT) && test_thread_flag(TIF_32BIT))

Arnd


\
 
 \ /
  Last update: 2015-12-07 12:41    [W:0.091 / U:1.488 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site