lkml.org 
[lkml]   [2015]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH -v2] mm, oom: introduce oom reaper
From
Date
Michal Hocko wrote:
> Yes you are right! The reference count should be incremented before
> publishing the new mm_to_reap. I thought that an elevated ref. count by
> the caller would be enough but this was clearly wrong. Does the update
> below looks better?

I think that moving mmdrop() from oom_kill_process() to
oom_reap_vmas() xor wake_oom_reaper() makes the patch simpler.

rcu_read_unlock();

+ if (can_oom_reap)
+ wake_oom_reaper(mm); /* will call mmdrop() */
+ else
+ mmdrop(mm);
- mmdrop(mm);
put_task_struct(victim);
}


\
 
 \ /
  Last update: 2015-12-07 23:41    [W:0.084 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site