lkml.org 
[lkml]   [2015]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 0/5] mfd: tps65912: Driver rewrite with DT support
On Thu, 03 Dec 2015, Andrew F. Davis wrote:

> On 11/24/2015 10:26 AM, Lee Jones wrote:
> >On Wed, 18 Nov 2015, Andrew F. Davis wrote:
> >
> >>In an effort to cleanup this driver and add Device Tree support
> >>the driver has been rewritten based on new driver styles and
> >>modern kernel driver helpers. This has nearly halved the lines
> >>of code while keeping all previous functionality.
> >>
> >>Platform file based initialization has been dropped as there is
> >>no examples of this use in the kernel.
> >>
> >>v1 can be found here: [1] v2: [2] v3: [3] v4: [4] v5: [5] v6: [6]
> >>
> >>Changes from v6:
> >> - Removed compatible strings from DT sub-nodes
> >> - Rearranged DT bindings
> >> - Small fixes
> >>
> >>Changes from v5:
> >> - Small formatting changes to DT Docs
> >> - Converted to_tps65912_gpio from macro to inline function
> >>
> >>Changes from v4:
> >> - Use mfd core to add sub-devices
> >>
> >>Changes from v3:
> >> - Reorganized regulator driver and related DT node
> >> - Other small fixes as discussed in v3 thread
> >>
> >>Changes from v2:
> >> - Split the series further into subsystems
> >>
> >>Changes from v1:
> >> - Split the rewrite into delete/create patches
> >> - Several small fixes as discussed in v1 thread
> >>
> >>[1] http://www.spinics.net/lists/devicetree/msg93863.html
> >>[2] http://www.spinics.net/lists/devicetree/msg95003.html
> >>[3] http://www.spinics.net/lists/devicetree/msg95133.html
> >>[4] http://www.spinics.net/lists/devicetree/msg96109.html
> >>[5] http://www.spinics.net/lists/devicetree/msg100601.html
> >>[6] https://lkml.org/lkml/2015/10/30/690
> >>
> >>Andrew F. Davis (5):
> >> Documentation: tps65912: Add DT bindings for the TPS65912 PMIC
> >> mfd: tps65912: Remove old driver in preparation for new driver
> >> mfd: tps65912: Add driver for the TPS65912 PMIC
> >> regulator: tps65912: Add regulator driver for the TPS65912 PMIC
> >> gpio: tps65912: Add GPIO driver for the TPS65912 PMIC
> >>
> >> Documentation/devicetree/bindings/mfd/tps65912.txt | 50 ++
> >> drivers/gpio/Kconfig | 2 +-
> >> drivers/gpio/gpio-tps65912.c | 317 ++++-----
> >> drivers/mfd/Kconfig | 20 +-
> >> drivers/mfd/Makefile | 3 +-
> >> drivers/mfd/tps65912-core.c | 290 ++++-----
> >> drivers/mfd/tps65912-i2c.c | 219 +++----
> >> drivers/mfd/tps65912-irq.c | 217 -------
> >> drivers/mfd/tps65912-spi.c | 219 +++----
> >> drivers/regulator/Kconfig | 2 +-
> >> drivers/regulator/tps65912-regulator.c | 710 +++++----------------
> >> include/linux/mfd/tps65912.h | 208 +++---
> >
> >Just waiting for the regulator Ack now, right?
> >
>
> I believe so, is there a friendly way to poke Mark Brown so this doesn't
> get caught in his filter? This is almost identical to the regulator he
> applied the other day from me so I don't imagine there will be much problem
> with this patch.

Just repost the set with all the remaining Acks and explain in the
cover letter that you're only missing one Ack. I can prod Mark from
that point.

> >> 12 files changed, 780 insertions(+), 1477 deletions(-)
> >> create mode 100644 Documentation/devicetree/bindings/mfd/tps65912.txt
> >> rewrite drivers/gpio/gpio-tps65912.c (74%)
> >> rewrite drivers/mfd/tps65912-core.c (95%)
> >> rewrite drivers/mfd/tps65912-i2c.c (93%)
> >> delete mode 100644 drivers/mfd/tps65912-irq.c
> >> rewrite drivers/mfd/tps65912-spi.c (92%)
> >> rewrite drivers/regulator/tps65912-regulator.c (94%)
> >>
> >

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog


\
 
 \ /
  Last update: 2015-12-04 10:01    [W:0.079 / U:1.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site