Messages in this thread | | | Date | Fri, 4 Dec 2015 11:09:20 -0700 | From | Jason Gunthorpe <> | Subject | Re: [tpmdd-devel] [PATCH v2 0/3] tpm_tis: Clean up force module parameter |
| |
On Fri, Dec 04, 2015 at 10:10:15AM +0100, Wilck, Martin wrote:
> The following simple change fixes the ACPI probing after applying your > latest series. The must have been another ACPI resource that you were > erroneously using as mem resource.
Close, acpi_dev_resource_memory destroys it's output parameter when it fails :(
Should be:
if (acpi_dev_resource_interrupt(ares, 0, &res)) tpm_info->irq = res.start; else if (acpi_dev_resource_memory(ares, &res)) tpm_info->res = res;
> The IS_ERR change() didn't fix it. I think it's not needed, although it > probably can't hurt.
IS_ERR should address the oops though??
I've put all the revised patches here:
https://github.com/jgunthorpe/linux/commits/for-jarkko
If you are OK with them now I'll post the series.
Jason
| |