lkml.org 
[lkml]   [2015]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/7] perf test: Use machine__new_host in mma thread lookup test
Hi Jiri,

In the subject, please do 's/mma/mmap/'. Ditto for 3/7.

Thanks,
Namhyung


On Thu, Dec 03, 2015 at 09:34:13AM +0100, Jiri Olsa wrote:
> This is more straightforward than what we have now.
>
> It also fixes segfault within machine__exit, that's caused
> but not creating kernel maps for machine.. We're calling
> machine__destroy_kernel_maps in machine__exit since commit:
>
> ebe9729c8c31 perf machine: Fix to destroy kernel maps when machine exits
>
> Link: http://lkml.kernel.org/n/tip-h20rqr6nyuqvcjqdmixvy9fn@git.kernel.org
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>
> ---
> tools/perf/tests/mmap-thread-lookup.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/tools/perf/tests/mmap-thread-lookup.c b/tools/perf/tests/mmap-thread-lookup.c
> index 6cdb97579c45..0c5ce44f723f 100644
> --- a/tools/perf/tests/mmap-thread-lookup.c
> +++ b/tools/perf/tests/mmap-thread-lookup.c
> @@ -149,7 +149,6 @@ static int synth_process(struct machine *machine)
>
> static int mmap_events(synth_cb synth)
> {
> - struct machines machines;
> struct machine *machine;
> int err, i;
>
> @@ -162,8 +161,7 @@ static int mmap_events(synth_cb synth)
> */
> TEST_ASSERT_VAL("failed to create threads", !threads_create());
>
> - machines__init(&machines);
> - machine = &machines.host;
> + machine = machine__new_host();
>
> dump_trace = verbose > 1 ? 1 : 0;
>
> @@ -203,7 +201,7 @@ static int mmap_events(synth_cb synth)
> }
>
> machine__delete_threads(machine);
> - machines__exit(&machines);
> + machine__delete(machine);
> return err;
> }
>
> --
> 2.4.3
>


\
 
 \ /
  Last update: 2015-12-04 14:41    [W:0.967 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site