Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH 1/4] soc: mediatek: Separate scpsys driver common code | Date | Wed, 30 Dec 2015 09:52:19 +0100 |
| |
On Wednesday 30 December 2015 14:41:43 James Liao wrote: > diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig > index 0a4ea80..eca6fb7 100644 > --- a/drivers/soc/mediatek/Kconfig > +++ b/drivers/soc/mediatek/Kconfig > @@ -22,11 +22,20 @@ config MTK_PMIC_WRAP > > config MTK_SCPSYS > bool "MediaTek SCPSYS Support" > - depends on ARCH_MEDIATEK || COMPILE_TEST > - default ARM64 && ARCH_MEDIATEK > select REGMAP > select MTK_INFRACFG > select PM_GENERIC_DOMAINS if PM > help > Say yes here to add support for the MediaTek SCPSYS power domain > driver. > + > +config MTK_SCPSYS_MT8173 > + bool "MediaTek MT8173 SCPSYS Support" > + depends on ARCH_MEDIATEK || COMPILE_TEST > + select MTK_SCPSYS > + default ARCH_MEDIATEK >
Please don't "select" a user-visible Kconfig symbol. Either hide MTK_SCPSYS by removing the string behind 'bool', or make this "depends on MTK_SCPSYS".
Arnd
| |