Messages in this thread | | | Date | Thu, 3 Dec 2015 10:06:04 -0500 | From | Tejun Heo <> | Subject | Re: [PATCH 1/2] watchdog: introduce touch_softlockup_watchdog_sched() |
| |
On Thu, Dec 03, 2015 at 04:04:42PM +0100, Peter Zijlstra wrote: > On Thu, Dec 03, 2015 at 09:48:11AM -0500, Tejun Heo wrote: > > We can add MEM_RECLAIM -> !MEM_RECLAIM warning mechanism in addition > > but I think adding stall detection is justified. > > Sure, a stall mech is always nice, but I was thinking we should be able > to better catch some of these with explicit stuff.
Yeah, sure, I don't think we even need to meddle with lockdep. I'm gonna add WARN_ON_ONCE()s which trigger whenever something on reclaim path tries to flush !WQ_MEM_RECLAIM workqueues or work items.
Thanks.
-- tejun
| |