lkml.org 
[lkml]   [2015]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 1/1] atm: solos-pci: Replace simple_strtol by kstrtoint
From
Date
On Thu, 2015-12-03 at 09:06 +0100, LABBE Corentin wrote:
> @@ -357,11 +357,11 @@ static int process_status(struct solos_card *card, int port, struct sk_buff *skb
> if (!str)
> return -EIO;
>
> - ver = simple_strtol(str, NULL, 10);
> - if (ver < 1) {
> + err = kstrtoint(str, 10, &ver);
> + if (err || ver < 1) {
> dev_warn(&card->dev->dev, "Unexpected status interrupt version %d\n",
> ver);
> - return -EIO;
> + return err;


If ver < 1 then you might return a 0 here. Always returning -EIO is
probably just fine.




\
 
 \ /
  Last update: 2015-12-03 13:01    [W:0.059 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site