lkml.org 
[lkml]   [2015]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board
Date
On Thursday 03 December 2015 10:44:28 Jiancheng Xue wrote:

> +
> +/dts-v1/;
> +#include "hi3519.dtsi"
> +
> +/ {
> + model = "HiSilicon HI3519 DEMO Board";
> + compatible = "hisilicon,hi3519";
> +
> + chosen {
> + bootargs = "mem=64M console=ttyAMA0,115200 early_printk \
> +root=/dev/mtdblock2 rootfstype=jffs2 \
> +mtdparts=hi_sfc:1M(boot),4M(kernel),11M(rootfs)";
> + };

Most of the arguments should be dropped and replaced with the respective
DT properties in this file:

mem: /memory (you have that already, but the size seems wrong)
console: /chosen/stdout-path
early_printk: just drop this, maybe use "earlycon")
root: this one is fine
rootfstype: should not be needed
mtdparts: use nodes below the MTD device


> +
> +#include "skeleton.dtsi"
> +#include <dt-bindings/clock/hi3519-clock.h>
> +/ {
> + aliases {
> + serial0 = &uart0;
> + };

Move this into the .dts file.

> +
> + uart0: uart@12100000 {

rename to serial@12100000

> + dual_timer1: dual_timer@12001000 {
> + compatible = "arm,sp804", "arm,primecell";
> + interrupts = <0 66 4>, <0 67 4>;
> + reg = <0x12001000 0x1000>;
> + clocks = <&crg HI3519_FIXED_3M>;
> + status = "disable";
> + };

rename to timer@12001000

> + sysctrl: system-controller@12020000 {
> + compatible = "hisilicon,sysctrl";
> + reg = <0x12020000 0x1000>;
> + reboot-offset = <0x4>;
> + };

Is this one identical to the one in hip04?

If not, pick a new unique compatible string

> +
> + crg: crg@12010000 {
> + compatible = "hisilicon,hi3519-crg";


what is a "crg"? Is there a standard name for these?

Arnd


\
 
 \ /
  Last update: 2015-12-03 10:41    [W:0.107 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site