lkml.org 
[lkml]   [2015]   [Dec]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [Bugfix v2 1/5] x86/irq: Do not reuse struct apic_chip_data.old_domain as temporary buffer
From
Date
On 2015/12/24 13:15, Jeremiah Mahler wrote:
> Jiang,
>
> On Wed, Dec 23, 2015 at 10:13:26PM +0800, Jiang Liu wrote:
>> Function __assign_irq_vector() makes use of apic_chip_data.old_domain
>> as a temporary buffer, which causes trouble to rollback logic in case of
>> failure. So use a dedicated temporary buffer for __assign_irq_vector().
>>
>> Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
>> ---
>> arch/x86/kernel/apic/vector.c | 9 +++++----
>> 1 file changed, 5 insertions(+), 4 deletions(-)
> [...]
>
> I tried this patch and the rest in the series but unfortunately
> the bug is still present.
>
> [ 10.184649] wlan0: authenticated
> [ 10.187883] wlan0: associate with 02:1a:11:fb:90:1c (try 1/3)
> [ 10.191574] do_IRQ: 0.35 No irq handler for vector
> [ 10.191589] do_IRQ: 0.35 No irq handler for vector
> [ 10.198159] do_IRQ: 0.35 No irq handler for vector
> [ 10.198165] do_IRQ: 0.35 No irq handler for vector
> [ 10.200534] wlan0: RX AssocResp from 02:1a:11:fb:90:1c (capab=0x431
> status=0 aid=1)
> [ 10.204611] wlan0: associated
> [ 10.238883] do_IRQ: 0.35 No irq handler for vector
> [ 10.238892] do_IRQ: 0.35 No irq handler for vector
> [ 10.280716] do_IRQ: 0.35 No irq handler for vector
> [ 10.281083] do_IRQ: 0.35 No irq handler for vector
> [ 10.286484] do_IRQ: 0.35 No irq handler for vector
> ...
>
Hi Jeremiah,
Could you please help to confirm which commit caused the
regression?
1) x86/irq: Do not reuse struct apic_chip_data.old_domain as temporary
buffer
2) x86/irq: Fix a race condition between vector assigning and cleanup

Thanks,
Gerry


\
 
 \ /
  Last update: 2015-12-28 09:41    [W:2.326 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site