Messages in this thread | | | Date | Mon, 28 Dec 2015 17:42:50 -0300 | Subject | Re: [PATCH v2 00/12] mtd: nand_bbt: introduce independent nand BBT | From | Ezequiel Garcia <> |
| |
This is looking a lot better, thanks for the good work!
On 15 December 2015 at 02:59, Peter Pan <peterpansjtu@gmail.com> wrote: > Currently nand_bbt.c is tied with struct nand_chip, and it makes other > NAND family chips hard to use nand_bbt.c. Maybe it's the reason why > onenand has own bbt(onenand_bbt.c). > > Separate struct nand_chip from BBT code can make current BBT shareable. > We create struct nand_bbt to take place of nand_chip in nand_bbt.c. > Struct nand_bbt contains all the information BBT needed from outside and > it should be embedded into NAND family chip struct (such as struct nand_chip). > NAND family driver should allocate, initialize and free struct nand_bbt. > > Below is mtd folder structure we want: > mtd > ├── Kconfig > ├── Makefile > ├── ... > ├── nand_bbt.c
Hm.. I'm not sure about having nand_bbt.c in drivers/mtd. What's wrong with drivers/mtd/nand ?
In fact, I was thinking we could go further and clean up the directories a bit by separating core code, from controllers code, from SPI NAND code:
drivers/mtd/nand/ drivers/mtd/nand/controllers drivers/mtd/nand/spi
Makes any sense? -- Ezequiel García, VanguardiaSur www.vanguardiasur.com.ar
| |