Messages in this thread | | | Subject | Re: [RFC PATCH v1 1/2] drm: rockchip/hdmi: add Innosilicon HDMI support | From | Yakir Yang <> | Date | Mon, 21 Dec 2015 15:44:56 +0800 |
| |
Hi Mark,
On 12/21/2015 03:31 PM, Mark yao wrote: > On 2015年11月11日 15:46, Yakir Yang wrote: >> + hdmi->connector.polled = DRM_CONNECTOR_POLL_HPD; >> + >> + drm_connector_helper_add(&hdmi->connector, >> + &inno_hdmi_connector_helper_funcs); >> + drm_connector_init(drm, &hdmi->connector, >> &inno_hdmi_connector_funcs, >> + DRM_MODE_CONNECTOR_HDMIA); >> + >> + hdmi->connector.encoder = encoder; > > Pls remove "hdmi->connector.encoder = encoder;" > > It would cause a error dump on atomic drm runtime: > > WARNING: CPU: 3 PID: 74 at drivers/gpu/drm/drm_atomic_helper.c:682 > drm_atomic_helper_update_legacy_modeset_state+0x6c/0x200() > > This issue can be explained from following thread: > https://lkml.org/lkml/2015/11/16/498 >
Done, thanks
- Yakir
> Thanks. >
| |