Messages in this thread | | | Subject | Re: [PATCH 1/1] HID: multitouch: enable palm rejection if device implements confidence usage | From | Allen Hung <> | Date | Mon, 21 Dec 2015 17:45:07 +0800 |
| |
On 12/18/2015 05:52 AM, Benjamin Tissoires wrote: > On Thu, Nov 26, 2015 at 3:21 PM, Jiri Kosina <jikos@kernel.org> wrote: >> On Fri, 20 Nov 2015, Allen Hung wrote: >> >>> The usage Confidence is mandary to Windows Precision Touchpad devices. The >>> appearance of this usage is checked in hidinput_connect but the quirk >>> MT_QUIRK_VALID_IS_CONFIDENCE is not applied to device accordingly. >>> Apply this quirk and also remove quirk MT_QUIRK_ALWAYS_VALID to enable palm >>> rejection for the WIN 8 touchpad devices which have implemented usage >>> Confidence in its input reports. >>> >>> Tested on Dell XPS 13 laptop. >>> >>> Signed-off-by: Allen Hung <allen_hung@dell.com> >> Applied to for-4.5/multitouch. Thanks, >> > Allen, looks like the Dell XPS13 2015 (or was it the 2014?) has > problems with your patch: > https://bugzilla.redhat.com/show_bug.cgi?id=1292583 (we backported > this change in the Fedora kernel 4.2.7). > > Would you mind checking that this patch does not create regressions on > older series of laptops? > > Thanks in advance. > > Cheers, > Benjamin Hi Benjamin,
It looks like a XPS13 2014 but I can confirm this with my colleagues who are in charge of this product line. I don't mind checking this patch with more older series of laptops. I will do it and let you know the status. Should I also test the machines with Fedora 23, or just go with Ubuntu OS? The XPS machines are shipped with Ubuntu. Btw, the issue reporter said she/he cannot reproduce the issue (posted on Dec. 18).
Regards, Allen Hung
| |