Messages in this thread | | | Subject | Re: [PATCH (v6) 1/2] mtd: brcmnand: Add brcm,bcm63268-nand device tree binding | From | Simon Arlott <> | Date | Wed, 2 Dec 2015 20:12:32 +0000 |
| |
On 02/12/15 20:00, Brian Norris wrote: > Hi, > > On Wed, Dec 02, 2015 at 07:41:07PM +0000, Simon Arlott wrote: >> >> + nand0: nandcs@0 { >> >> + compatible = "brcm,nandcs"; >> >> + >> >> + #address-cells = <0>; >> >> + #size-cells = <0>; > >> I think they're also implicit so you can just remove those two lines. > > From ePAPR: "The #address-cells and #size-cells properties are not > inherited from ancestors in the device tree. They shall be explicitly > defined." > > But we don't want to define them. I'd drop them, at least from the > example, as they're not relevant.
Ok.
>> I've created a bcm963268part driver so there won't need to be any >> partitions in DT for bcm63268. > > Just curious, do you plan to submit this driver? We're working on
Yes, it's just the most recent one I've been working on. I still have USBH and IUDMA to submit
> matching up partition parsers to flash devices via device tree > of_match_table's, so you could do something like this: > > nand0: nandcs@0 { > compatible = "brcm,nandcs"; > ... > > partitions { > compatible = "brcm,bcm963268-partitions"; > ... > }; > };
I modified brcmnand to look for a machine matching "brcm,bcm963268", but that way is ok with me. Presumably "ofpart" defers to another matching partition parser?
Is there a patch for that method of parser detection available?
-- Simon Arlott
| |