lkml.org 
[lkml]   [2015]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] block: add calls to split trace point
On Wed, Dec 02, 2015 at 10:06:09AM -0700, Jens Axboe wrote:
> On 12/02/2015 01:25 AM, Mike Krinkin wrote:
> >Hi Jens,
> >
> >i would like to check status of the patch, will the patch be applied?
> >
>
> Why aren't you just putting the split trace call into blk_queue_split()?

Do you mean after split? Something like this:

if (split) {
/* there isn't chance to merge the splitted bio */
split->bi_rw |= REQ_NOMERGE;

bio_chain(split, *bio);
trace_block_split(q, split, bio->bi_iter.bi_sector);
generic_make_request(*bio);
*bio = split;
}

block_split trace event docs says that it expects "bio being split", i
understood it as "bio before split". But scarcely someone depends on
this behaviour, so i'll resend the patch, is it ok?


\
 
 \ /
  Last update: 2015-12-02 20:21    [W:0.054 / U:2.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site