Messages in this thread | | | Date | Wed, 02 Dec 2015 19:09:13 +0000 | From | Johannes Thumshirn <> | Subject | Re: [PATCH 1/2] edac: mpc52xx: Use platform_register/unregister_drivers() |
| |
The subject is reading mpc52xx instead of mpc85xx but other than that
Reviewed-by: Johannes Thumshirn <jthumshirn@suse>
Zitat von Thierry Reding <thierry.reding@gmail.com>:
> From: Thierry Reding <treding@nvidia.com> > > These new helpers simplify implementing multi-driver modules and > properly handle failure to register one driver by unregistering all > previously registered drivers. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/edac/mpc85xx_edac.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c > index 23ef8e9f2c9a..3eab06351089 100644 > --- a/drivers/edac/mpc85xx_edac.c > +++ b/drivers/edac/mpc85xx_edac.c > @@ -1208,6 +1208,11 @@ static void __init mpc85xx_mc_clear_rfxe(void *data) > } > #endif > > +static struct platform_driver * const drivers[] = { > + &mpc85xx_mc_err_driver, > + &mpc85xx_l2_err_driver, > +}; > + > static int __init mpc85xx_mc_init(void) > { > int res = 0; > @@ -1226,13 +1231,9 @@ static int __init mpc85xx_mc_init(void) > break; > } > > - res = platform_driver_register(&mpc85xx_mc_err_driver); > - if (res) > - printk(KERN_WARNING EDAC_MOD_STR "MC fails to register\n"); > - > - res = platform_driver_register(&mpc85xx_l2_err_driver); > + res = platform_register_drivers(drivers, ARRAY_SIZE(drivers)); > if (res) > - printk(KERN_WARNING EDAC_MOD_STR "L2 fails to register\n"); > + printk(KERN_WARNING EDAC_MOD_STR "drivers fail to register\n"); > > #ifdef CONFIG_FSL_SOC_BOOKE > pvr = mfspr(SPRN_PVR); > @@ -1270,8 +1271,7 @@ static void __exit mpc85xx_mc_exit(void) > on_each_cpu(mpc85xx_mc_restore_hid1, NULL, 0); > } > #endif > - platform_driver_unregister(&mpc85xx_l2_err_driver); > - platform_driver_unregister(&mpc85xx_mc_err_driver); > + platform_unregister_drivers(drivers, ARRAY_SIZE(drivers)); > } > > module_exit(mpc85xx_mc_exit); > -- > 2.5.0 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-edac" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
| |