lkml.org 
[lkml]   [2015]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] oom_kill: add option to disable dump_stack()
    On Tue 01-12-15 15:43:53, Andrew Morton wrote:
    [...]
    > > diff --git a/mm/oom_kill.c b/mm/oom_kill.c
    > > index 1ecc0bc..bdbf83b 100644
    > > --- a/mm/oom_kill.c
    > > +++ b/mm/oom_kill.c
    > > @@ -42,6 +42,7 @@
    > > int sysctl_panic_on_oom;
    > > int sysctl_oom_kill_allocating_task;
    > > int sysctl_oom_dump_tasks = 1;
    > > +int sysctl_oom_dump_stack = 1;
    > >
    > > DEFINE_MUTEX(oom_lock);
    > >
    > > @@ -384,7 +385,8 @@ static void dump_header(struct oom_control *oc, struct task_struct *p,
    > > current->signal->oom_score_adj);
    > > cpuset_print_task_mems_allowed(current);
    > > task_unlock(current);
    > > - dump_stack();
    > > + if (sysctl_oom_dump_stack)
    > > + dump_stack();
    > > if (memcg)
    > > mem_cgroup_print_oom_info(memcg, p);
    > > else
    >
    > The patch seems reasonable to me, but it's missing the required update
    > to Documentation/sysctl/vm.txt.

    I thought we have agreed to go via KERN_DEBUG log level for the
    backtrace. Aristeu has posted a patch for that already.
    --
    Michal Hocko
    SUSE Labs


    \
     
     \ /
      Last update: 2015-12-02 09:41    [W:2.690 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site