lkml.org 
[lkml]   [2015]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] sched/core: Clear the root_domain cpumasks in init_rootdomain()
From
Date
Hi Peter,

On 12/02/2015 at 08:34 PM, Peter Zijlstra wrote:
> On Wed, Dec 02, 2015 at 07:52:59PM +0800, Xunlei Pang wrote:
>> The patch cleans the garbage by using zalloc_cpumask_var()
>> instead of alloc_cpumask_var() for root_domain::rto_mask
>> allocation, thereby addressing the issues.
> How did you notice this? Also do we want to do the same for the kmalloc

When doing review.

> in alloc_rootdomain() ?

There is a "memset(rd, 0, sizeof(*rd))" in init_rootdomain(),
so I don't think we need to do this in alloc_rootdomain().

Regards,
Xunlei


\
 
 \ /
  Last update: 2015-12-02 14:41    [W:0.059 / U:0.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site