lkml.org 
[lkml]   [2015]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 21/40] staging: lustre: improve LNet clean up code and API
Actually we're going to have to redo so much code that it's not worth it
for me to review the rest of these patches. Please just look over
everything again:

BAD: return -1;
GOOD: return -EINVAL;

BAD: failed0:
GOOD: free_something:

BAD: if (rc != 0)
GOOD: if (rc)

Do one thing per patch.
Do not introduce a bug and then fix it in a later patch.
Check ioc_len more carefully.
Don't make the code look ugly just to please checkpatch.pl.
Do error handling not success handling.
Try to avoid indenting a far to the right.


regards,
dan carpenter


\
 
 \ /
  Last update: 2015-12-02 14:21    [W:0.330 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site