Messages in this thread Patch in this message | | | From | Xunlei Pang <> | Subject | [PATCH v2 3/3] sched/cpudeadline: Cleanup of duplicate memory initialization | Date | Thu, 3 Dec 2015 12:45:01 +0800 |
| |
There is already a memset clear operation for '*cp', so we can use alloc_cpumask_var() with __GFP_ZERO instead of zalloc_cpumask_var() to avoid duplicate clear for systems without CONFIG_CPUMASK_OFFSTACK set.
Also omit "cp->size = 0;".
Signed-off-by: Xunlei Pang <xlpang@redhat.com> --- kernel/sched/cpudeadline.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/sched/cpudeadline.c b/kernel/sched/cpudeadline.c index 5a75b08..ca780ec 100644 --- a/kernel/sched/cpudeadline.c +++ b/kernel/sched/cpudeadline.c @@ -211,7 +211,6 @@ int cpudl_init(struct cpudl *cp) memset(cp, 0, sizeof(*cp)); raw_spin_lock_init(&cp->lock); - cp->size = 0; cp->elements = kcalloc(nr_cpu_ids, sizeof(struct cpudl_item), @@ -219,7 +218,7 @@ int cpudl_init(struct cpudl *cp) if (!cp->elements) return -ENOMEM; - if (!zalloc_cpumask_var(&cp->free_cpus, GFP_KERNEL)) { + if (!alloc_cpumask_var(&cp->free_cpus, GFP_KERNEL | __GFP_ZERO)) { kfree(cp->elements); return -ENOMEM; } -- 2.5.0
| |