lkml.org 
[lkml]   [2015]   [Dec]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V2 2/7] mm/gup: add gup trace points
From
Date
On 12/02/2015 02:53 PM, Yang Shi wrote:
> diff --git a/mm/gup.c b/mm/gup.c
> index deafa2c..10245a4 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -13,6 +13,9 @@
> #include <linux/rwsem.h>
> #include <linux/hugetlb.h>
>
> +#define CREATE_TRACE_POINTS
> +#include <trace/events/gup.h>
> +
> #include <asm/pgtable.h>
> #include <asm/tlbflush.h>

This needs to be _the_ last thing that gets #included. Otherwise, you
risk colliding with any other trace header that gets implicitly included
below.

> @@ -1340,6 +1346,8 @@ int __get_user_pages_fast(unsigned long start, int nr_pages, int write,
> start, len)))
> return 0;
>
> + trace_gup_get_user_pages_fast(start, nr_pages, write, pages);
> +
> /*
> * Disable interrupts. We use the nested form as we can already have
> * interrupts disabled by get_futex_key.

It would be _really_ nice to be able to see return values from the
various gup calls as well. Is that feasible?


\
 
 \ /
  Last update: 2015-12-03 01:01    [W:0.095 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site