Messages in this thread | | | Date | Wed, 2 Dec 2015 14:16:50 -0800 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2] usb: ehci: ohci: use true/false for bool |
| |
On Wed, Dec 02, 2015 at 07:09:19PM -0300, Geyslan G. Bem wrote: > When declaring/initializing bool use true instead of 1. If it's false, > there's no need to explicit initialize it, once it's default. > > Caught by coccinelle. > > Signed-off-by: Geyslan G. Bem <geyslan@gmail.com> > --- > drivers/usb/host/ehci-hcd.c | 2 +- > drivers/usb/host/ohci-hcd.c | 4 ++-- > drivers/usb/host/u132-hcd.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c > index 48c92bf..1b01967 100644 > --- a/drivers/usb/host/ehci-hcd.c > +++ b/drivers/usb/host/ehci-hcd.c > @@ -98,7 +98,7 @@ module_param (park, uint, S_IRUGO); > MODULE_PARM_DESC (park, "park setting; 1-3 back-to-back async packets"); > > /* for flakey hardware, ignore overcurrent indicators */ > -static bool ignore_oc = 0; > +static bool ignore_oc;
This should be a separate patch as it's doing something differently than what you describe.
thanks,
greg k-h
| |