lkml.org 
[lkml]   [2015]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2] mtd: spi-nor: fsl-quadspi: add big-endian support
Date
Hi Woodhouse, Norris,

Do you have any comments for this patch?

Thanks for your review.

Best Regards,
Yuan Yao

> -----Original Message-----
> From: Han Xu [mailto:han.xu@freescale.com]
> Sent: Thursday, November 26, 2015 3:09 AM
> To: Yuan Yao-B46683 <yao.yuan@freescale.com>
> Cc: dwmw2@infradead.org; computersforpeace@gmail.com; linux-
> kernel@vger.kernel.org; linux-mtd@lists.infradead.org
> Subject: Re: [PATCH v2] mtd: spi-nor: fsl-quadspi: add big-endian support
On Thu, Nov 26, 2015 at
> On Wed, Nov 18, 2015 at 05:13:28PM +0800, Yuan Yao wrote:
> > Add R/W functions for big- or little-endian registers:
> > The qSPI controller's endian is independent of the CPU core's endian.
> > So far, the qSPI have two versions for big-endian and little-endian.
> >
> > Signed-off-by: Yuan Yao <yao.yuan@freescale.com>
> > ---
> > Changed in v2:
> > Rebase to the lastest code.
> > ---
> > drivers/mtd/spi-nor/fsl-quadspi.c | 157
> > +++++++++++++++++++++++---------------
> > 1 file changed, 97 insertions(+), 60 deletions(-)
> >
> > diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c
> > b/drivers/mtd/spi-nor/fsl-quadspi.c
> > index 9e7f657..0ce7768 100644

...

> > @@ -954,6 +990,7 @@ static int fsl_qspi_probe(struct platform_device
> *pdev)
> > if (IS_ERR(q->iobase))
> > return PTR_ERR(q->iobase);
> >
> > + q->big_endian = of_property_read_bool(np, "big-endian");
>
> I am fine with this patch, but need document the new property with another
> patch
>
> > res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> > "QuadSPI-memory");
> > if (!devm_request_mem_region(dev, res->start, resource_size(res),
> @@

...

> >
>
> Acked-by: Han xu <han.xu@freescale.com>
> --

Best Regards,
Yuan Yao


\
 
 \ /
  Last update: 2015-12-18 11:01    [W:0.082 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site