Messages in this thread | | | Subject | Re: [RFC PATCH] lpfc: Add lockdep assertions | From | Bart Van Assche <> | Date | Thu, 17 Dec 2015 08:19:38 +0100 |
| |
On 11/20/2015 01:37 PM, Johannes Thumshirn wrote: > Several functions in lpfc have comments stating that the function must be > called with the hbalock (or hostlock, or ringlock) held. Add > lockdep_assert_held() annotations to these functions, so one can actually > verify the locks are held. > > [ ... ] > > @@ -2647,6 +2675,7 @@ lpfc_sli_iocbq_lookup(struct lpfc_hba *phba, > { > struct lpfc_iocbq *cmd_iocb = NULL; > uint16_t iotag; > + lockdep_assert_held(&phba->hbalock); > > iotag = prspiocb->iocb.ulpIoTag;
(replying to an e-mail of one month ago)
Please leave a blank line after declarations. Checkpatch should have reported this. Anyway:
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
| |