Messages in this thread | | | Date | Thu, 17 Dec 2015 22:18:39 +0530 | From | Sudip Mukherjee <> | Subject | Re: [PATCH] drivers/tty/serial: delete unused MODULE_DEVICE_TABLE from atmel_serial.c |
| |
On Thu, Dec 17, 2015 at 10:05:46AM -0500, Paul Gortmaker wrote: > In commit c39dfebc7798956fd2140ae6321786ff35da30c3 ("drivers/tty/serial: > make serial/atmel_serial.c explicitly non-modular") we removed the code > relating to modular support since it currently only supports built in. > > However, when redoing my build coverage for mips allmodconfig, which > sets CONFIG_OF, I noticed a remaining line that needs to be removed, > else we will get a build failure for an undefined module macro. > > Unfortunately this didn't appear for any of the other arch I tested > more frequently, such as ARM. > > Since MODULE_DEVICE_TABLE is a no-op for non-modular code, we can just > remove the offending line. > > Fixes: c39dfebc7798 ("drivers/tty/serial: make serial/atmel_serial.c explicitly non-modular") > Cc: Nicolas Ferre <nicolas.ferre@atmel.com> > Cc: Jiri Slaby <jslaby@suse.com> > Cc: linux-serial@vger.kernel.org > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Sudip Mukherjee <sudip@vectorindia.org> > Reported-by: Sudip Mukherjee <sudip@vectorindia.org>
Acked-by: Sudip Mukherjee <sudip@vectorindia.org>
regards sudip
| |