Messages in this thread | | | From | Måns Rullgård <> | Subject | Re: [PATCH 3/3] ata: sata_dwc_460ex: get rid of global data | Date | Thu, 17 Dec 2015 15:57:57 +0000 |
| |
Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
> On Thu, 2015-12-17 at 15:19 +0000, Måns Rullgård wrote: >> Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes: >> >> > On Tue, 2015-12-15 at 23:25 +0000, Mans Rullgard wrote: >> > > This moves all global data into the driver private struct, thus >> > > permitting multiple devices of this type to be used. >> > > >> > >> > Nice! >> > >> > Btw, last time Linus complained about new warnings. Most of them I >> > have >> > fixed when moved to external DMA driver. Leftovers IIRC are related >> > to >> > address space. Are you going to fix them? Otherwise it might be a >> > headache for him again with strong wording to our address I >> > suppose. >> >> There are some issues with __iomem annotations. Is that the warnings >> you refer to? I'm not getting any regular compiler warnings. >> > > I guess I got them because I'am checking sparse warnings as well. > > There is the original Linus' complain. > http://permalink.gmane.org/gmane.linux.ide/59391
He's right, those casts are ugly and possibly wrong. I was thinking of cleaning it up, but first I wanted to get it working at all with my hardware.
-- Måns Rullgård
| |