Messages in this thread | | | Subject | Re: [PATCH 08/11] tty: serial: 8250: Add parentheses to macro | From | Andy Shevchenko <> | Date | Thu, 17 Dec 2015 17:16:41 +0200 |
| |
On Wed, 2015-12-16 at 16:36 +0100, Anton Wuerfel wrote: > This patch fixes a checkpatch warning caused by missing parentheses > in the definition of a macro. > > Signed-off-by: Anton Würfel <anton.wuerfel@fau.de> > Signed-off-by: Phillip Raffeck <phillip.raffeck@fau.de> > CC: linux-kernel@i4.cs.fau.de > --- > drivers/tty/serial/8250/8250_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/8250/8250_core.c > b/drivers/tty/serial/8250/8250_core.c > index 67147b2..3c29530 100644 > --- a/drivers/tty/serial/8250/8250_core.c > +++ b/drivers/tty/serial/8250/8250_core.c > @@ -686,7 +686,7 @@ static int __init univ8250_console_init(void) > } > console_initcall(univ8250_console_init); > > -#define SERIAL8250_CONSOLE &univ8250_console > +#define SERIAL8250_CONSOLE (&univ8250_console)
What about the rest of the drivers under drivers/tty/serial?
What do you propose to do with, for example, the following
drivers/tty/serial/cpm_uart/cpm_uart_core.c:1392:#define CPM_UART_CONSOLE &cpm_scc_uart_console drivers/tty/serial/cpm_uart/cpm_uart_core.c:1394:#define CPM_UART_CONSOLE NULL
> #else > #define SERIAL8250_CONSOLE NULL > #endif
-- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy
| |