Messages in this thread | | | Date | Thu, 17 Dec 2015 14:26:02 +0100 | Subject | Re: [RFC PATCH V2 5/8] irqchip/gic: Return an error if GIC initialisation fails | From | Linus Walleij <> |
| |
On Thu, Dec 17, 2015 at 11:48 AM, Jon Hunter <jonathanh@nvidia.com> wrote:
> If the GIC initialisation fails, then currently we do not return an error > or clean-up afterwards. Although for root controllers, this failure may be > fatal anyway, for secondary controllers, it may not be fatal and so return > an error on failure and clean-up. > > Also for non-banked GIC controllers, make sure that we free any memory > allocated if we fail to initialise the IRQ domain. > > Signed-off-by: Jon Hunter <jonathanh@nvidia.com> (...)
Almost perfect but...
> +err: > + if (IS_ENABLED(CONFIG_GIC_NON_BANKED) && percpu_offset) { > + free_percpu(gic->dist_base.percpu_base); > + free_percpu(gic->cpu_base.percpu_base);
What if the first map worked but not the second?
Should it be:
if (gic->dist_base.percpu_base) free_percpu(gic->dist_base.percpu_base); if (gic->cpu_base.percpu_base) free_percpu(gic->cpu_base.percpu_base);
?
Yours, Linus Walleij
| |