lkml.org 
[lkml]   [2015]   [Dec]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 11/38] HSI: omap_ssi: fix handling ida_simple_get result
From
Date
Hi,

Ping - almost three months passed.

Regards
Andrzej


On 09/21/2015 03:33 PM, Andrzej Hajda wrote:
> The function can return negative value.
>
> The problem has been detected using proposed semantic patch
> scripts/coccinelle/tests/unsigned_lesser_than_zero.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2038576
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
> drivers/hsi/controllers/omap_ssi.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/hsi/controllers/omap_ssi.c b/drivers/hsi/controllers/omap_ssi.c
> index 089c6c3..5d9225f 100644
> --- a/drivers/hsi/controllers/omap_ssi.c
> +++ b/drivers/hsi/controllers/omap_ssi.c
> @@ -336,11 +336,10 @@ static int __init ssi_add_controller(struct hsi_controller *ssi,
> return -ENOMEM;
> }
>
> - ssi->id = ida_simple_get(&platform_omap_ssi_ida, 0, 0, GFP_KERNEL);
> - if (ssi->id < 0) {
> - err = ssi->id;
> + err = ida_simple_get(&platform_omap_ssi_ida, 0, 0, GFP_KERNEL);
> + if (err < 0)
> goto out_err;
> - }
> + ssi->id = err;
>
> ssi->owner = THIS_MODULE;
> ssi->device.parent = &pd->dev;



\
 
 \ /
  Last update: 2015-12-14 12:01    [W:0.068 / U:0.428 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site