lkml.org 
[lkml]   [2015]   [Dec]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v3 02/10] usb: host: ehci-sched: move constants to right
    Date
    This patch moves the constants to right.

    Tested by compilation only.
    Caught by coccinelle:
    scripts/coccinelle/misc/compare_const_fl.cocci

    Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
    ---
    drivers/usb/host/ehci-sched.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c
    index e9f2ee7..c1d323c 100644
    --- a/drivers/usb/host/ehci-sched.c
    +++ b/drivers/usb/host/ehci-sched.c
    @@ -330,7 +330,7 @@ static int __maybe_unused same_tt(struct usb_device *dev1,
    */
    static inline unsigned char tt_start_uframe(struct ehci_hcd *ehci, __hc32 mask)
    {
    - unsigned char smask = QH_SMASK & hc32_to_cpu(ehci, mask);
    + unsigned char smask = hc32_to_cpu(ehci, mask) & QH_SMASK;
    if (!smask) {
    ehci_err(ehci, "invalid empty smask!\n");
    /* uframe 7 can't have bw so this will indicate failure */
    @@ -409,11 +409,11 @@ static int tt_available (
    * must be empty, so as to not illegally delay
    * already scheduled transactions
    */
    - if (125 < usecs) {
    + if (usecs > 125) {
    int ufs = (usecs / 125);

    for (i = uframe; i < (uframe + ufs) && i < 8; i++)
    - if (0 < tt_usecs[i])
    + if (tt_usecs[i] > 0)
    return 0;
    }

    --
    2.6.3


    \
     
     \ /
      Last update: 2015-12-13 18:21    [W:2.353 / U:1.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site