Messages in this thread | | | Date | Fri, 11 Dec 2015 15:01:49 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH 3/9] ACPI: add struct acpi_amba_quirk for AMD pl330 specific device config |
| |
On Fri, Dec 11, 2015 at 06:57:51AM +0000, Wang, Annie wrote: > >> + /* > >> + * If the ACPI device already has a node attached. It must be > >> + * renamed. > >> + */ > >> + if (quirk->quirk & MULTI_ATTACHED_QUIRK) > >> + sprintf(amba_devname, "%s%s", dev_name(&adev->dev), > >"DMA"); > >> + else > >> + memcpy(amba_devname, dev_name(&adev->dev), > >> + strlen(dev_name(&adev->dev))); > >> + > >> + amba_dev = amba_device_alloc(amba_devname, > >> resource->start, > >> resource_size(resource)); > >> > > > >Isn't this basially an MFD in a rather odd fashion?
MFD yes, odd perhaps made out here! > > > >I would have though having a device which just splits the resources then creates 2 > >children would be a whole lot simpler? > > Yup!
> > It seems more complex, if I trans an ACPI device to pdev, then attach 2 platform child nodes, > and create an amba device refer to one of the childs. Too many trans.
Sorry but I dont think that is right assumption, it will simper and PM would become easy
-- ~Vinod
| |