lkml.org 
[lkml]   [2015]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH linux-next 1/2] power: Add brcm,bcm6358-power-controller device tree binding
On Wed, Dec 09, 2015 at 10:29:35PM +0000, Simon Arlott wrote:
> The BCM6358 contains power domains controlled with a register. Power
> domains are indexed by bits in the register. Power domain bits can be
> interleaved with other status bits and clocks in the same register.
>
> Newer SoCs with dedicated power domain registers are active low.
>
> Signed-off-by: Simon Arlott <simon@fire.lp0.eu>
> ---
> .../power/brcm,bcm6358-power-controller.txt | 53 ++++++++++++++++++++++
> 1 file changed, 53 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/brcm,bcm6358-power-controller.txt
>
> diff --git a/Documentation/devicetree/bindings/power/brcm,bcm6358-power-controller.txt b/Documentation/devicetree/bindings/power/brcm,bcm6358-power-controller.txt
> new file mode 100644
> index 0000000..556c323
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/brcm,bcm6358-power-controller.txt
> @@ -0,0 +1,53 @@
> +Broadcom BCM6358 Power domain controller
> +
> +This binding uses the power domain bindings:
> + Documentation/devicetree/bindings/power/power_domain.txt
> +
> +The BCM6358 contains power domains controlled with a register. Power
> +domains are indexed by bits in the register. Power domain bits can be
> +interleaved with other status bits and clocks in the same register.
> +
> +Newer SoCs with dedicated power domain registers are active low.
> +
> +Required properties:
> +- compatible: Should be "brcm,bcm<soc>-power-controller", "brcm,bcm6358-power-controller"
> +- #power-domain-cells: Should be <1>.
> +- regmap: The register map phandle
> +- offset: Offset in the register map for the power domain register (in bytes)
> +- power-domain-indices: The bits in the register used for power domains.
You should drop this and make the cell values be the register offsets.

> +- power-domain-names: Should be a list of strings of power domain names
> + indexed by the power domain indices.

This isn't really needed anyway.

> +
> +Optional properties:
> +- active-low: Specify that the bits are active low.

This should be implied by the compatible property.

Rob


\
 
 \ /
  Last update: 2015-12-11 04:01    [W:0.055 / U:0.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site