lkml.org 
[lkml]   [2015]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] unix: avoid use-after-free in ep_remove_wait_queue
From
From: Rainer Weikusat <rweikusat@mobileactivedefense.com>
Date: Mon, 09 Nov 2015 14:40:48 +0000

> + __remove_wait_queue(&unix_sk(u->peer_wake.private)->peer_wait,
> + &u->peer_wake);

This is more simply:

__remove_wait_queue(&unix_sk(u->peer_wake.private)->peer_wait, q);

> +static inline int unix_dgram_peer_recv_ready(struct sock *sk,
> + struct sock *other)

Please do not us the inline keyword in foo.c files, let the compiler
decide.

Thanks.


\
 
 \ /
  Last update: 2015-11-09 20:01    [W:0.365 / U:0.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site