Messages in this thread | | | Date | Mon, 9 Nov 2015 19:39:10 +0300 | From | Dan Carpenter <> | Subject | Re: [kernel-hardening] Re: [PATCH] video: constify geode ops structures |
| |
On Mon, Nov 09, 2015 at 02:50:47PM +0000, Julia Lawall wrote: > > > On Mon, 9 Nov 2015, Dan Carpenter wrote: > > > Actually, it looks like Emese Revfy is going to merge the GCC plugin > > constify stuff sooner rather than later so maybe adding all these consts > > isn't going to be needed. > > Is there any advantage of const over the plugin? The consts are easy to > add.
Less syntax. It's a whitelist instead of blacklist so we don't miss anything.
> > Does the plugin help for structures that have non-function fields?
Yeah. You can mark a struct as __do_const in the .h file and it will make them all const automatically.
regards, dan carpenter
| |