Messages in this thread | | | Date | Mon, 9 Nov 2015 14:09:42 +0100 | Subject | Re: [PATCH 12/26] Input: synaptics-rmi4: Use generic interrupt handling | From | Linus Walleij <> |
| |
On Fri, Nov 6, 2015 at 12:40 AM, Andrew Duggan <aduggan@synaptics.com> wrote:
> Currently the RMI4 driver expects the device to have a GPIO and manages > the that GPIO internally. However, this duplicates functionality which > could be handled by more generic interrupt handling code. Also, some > RMI devices will not have a GPIO or it won't be accessible to the rmi4 > driver. This patch removes the GPIO code and instead gets the irq passed > up from the underlying transport (ie i2c-core). > > Signed-off-by: Andrew Duggan <aduggan@synaptics.com>
This is much better and should be squashed into the core patch adding the bus. The other GPIO cruft I was talking about seems to be going away with this and abstract away things nicely. Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |