lkml.org 
[lkml]   [2015]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 12/26] Input: synaptics-rmi4: Use generic interrupt handling
From
On Fri, Nov 6, 2015 at 12:40 AM, Andrew Duggan <aduggan@synaptics.com> wrote:

> Currently the RMI4 driver expects the device to have a GPIO and manages
> the that GPIO internally. However, this duplicates functionality which
> could be handled by more generic interrupt handling code. Also, some
> RMI devices will not have a GPIO or it won't be accessible to the rmi4
> driver. This patch removes the GPIO code and instead gets the irq passed
> up from the underlying transport (ie i2c-core).
>
> Signed-off-by: Andrew Duggan <aduggan@synaptics.com>

This is much better and should be squashed into the core patch adding
the bus. The other GPIO cruft I was talking about seems to be going
away with this and abstract away things nicely.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij


\
 
 \ /
  Last update: 2015-11-09 14:21    [W:0.039 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site