lkml.org 
[lkml]   [2015]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Input: parkbd - Drop bogus __init from parkbd_allocate_serio()
On Sat, Nov 07, 2015 at 04:53:23PM +0100, Geert Uytterhoeven wrote:
> WARNING: vmlinux.o(.text+0x1056606): Section mismatch in reference from the function parkbd_attach() to the function .init.text:parkbd_allocate_serio()
> The function parkbd_attach() references
> the function __init parkbd_allocate_serio().
> This is often because parkbd_attach lacks a __init
> annotation or the annotation of parkbd_allocate_serio is wrong.
>
> Commit 33ca8ab97cbb676d ("Input: parkbd - use parallel port device
> model") dropped the __init attribute from the sole caller of
> parkbd_allocate_serio(), but forgot to remove it from
> parkbd_allocate_serio() itself.
>
> Fixes: 33ca8ab97cbb676d ("Input: parkbd - use parallel port device model")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

I don't see this with allmodconfig on i386 or on x86_64. How did you get
this warning? But anyway, looking at the code, i did miss attribute.

Acked-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>

regards
sudip


\
 
 \ /
  Last update: 2015-11-09 14:21    [W:2.030 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site