lkml.org 
[lkml]   [2015]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dma: fix returnvar.cocci warnings
On 11/08/2015 07:45 AM, Julia Lawall wrote:
> Remove unneeded variable used to store return value.
>
> --- a/drivers/dma/qcom/hidma_ll.c
> +++ b/drivers/dma/qcom/hidma_ll.c
> @@ -567,14 +567,13 @@ int hidma_ll_resume(struct hidma_lldev *
>
> static int hidma_ll_hw_start(struct hidma_lldev *lldev)
> {
> - int rc = 0;
> unsigned long irqflags;
>
> spin_lock_irqsave(&lldev->lock, irqflags);
> writel(lldev->tre_write_offset, lldev->trca + TRCA_DOORBELL_OFFSET);
> spin_unlock_irqrestore(&lldev->lock, irqflags);
>
> - return rc;
> + return 0;
> }
>
> bool hidma_ll_isenabled(struct hidma_lldev *lldev)

Seems rather pointless, what about 'static void ...' and dropping the
return statement?


Daniel K.



\
 
 \ /
  Last update: 2015-11-08 23:21    [W:2.728 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site