Messages in this thread | | | From | Andy Lutomirski <> | Date | Sun, 8 Nov 2015 08:16:11 -0800 | Subject | Re: [PATCH 3/4] x86/asm: Add asm macros for static keys/jump labels |
| |
On Sat, Nov 7, 2015 at 9:08 AM, Thomas Gleixner <tglx@linutronix.de> wrote: > On Sat, 7 Nov 2015, Andy Lutomirski wrote: >> On Sat, Nov 7, 2015 at 8:58 AM, Thomas Gleixner <tglx@linutronix.de> wrote: >> True. But I hid it in a header file, too, but it was just a different >> header file -- I had it all hidden away as CALL_ENTER_FROM_USER_MODE. > > It probably does not really make a difference :) > > I just got triggered by you saying: > >> Unfortunately, these only work if HAVE_JUMP_LABEL .... >
Looking again, my patch is crappy is one obvious respect: on non-HAVE_JUMP_LABEL kernels, I'm still generating a macro that will compile but do the wrong thing. I'll add better comments and the correct ifdef in v2. That will make it much harder to screw up without causing a compiler error.
--Andy
| |