Messages in this thread Patch in this message | | | From | Geliang Tang <> | Subject | [PATCH 1/2] zram: fix memory freeing in zram_meta_alloc | Date | Sun, 8 Nov 2015 23:32:18 +0800 |
| |
When meta->table is NULL, there is no need to vfree it.
Signed-off-by: Geliang Tang <geliangtang@163.com> --- drivers/block/zram/zram_drv.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index 81a557c..197a7ad 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -511,7 +511,7 @@ static struct zram_meta *zram_meta_alloc(char *pool_name, u64 disksize) meta->table = vzalloc(num_pages * sizeof(*meta->table)); if (!meta->table) { pr_err("Error allocating zram address table\n"); - goto out_error; + goto out_free; } meta->mem_pool = zs_create_pool(pool_name, GFP_NOIO | __GFP_HIGHMEM); @@ -524,6 +524,7 @@ static struct zram_meta *zram_meta_alloc(char *pool_name, u64 disksize) out_error: vfree(meta->table); +out_free: kfree(meta); return NULL; } -- 2.5.0
| |