Messages in this thread | | | Date | Sat, 7 Nov 2015 10:19:54 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH] Preserve task state in reentrant calls to ___wait_event |
| |
On Fri, Nov 06, 2015 at 08:44:08PM +0000, Chris Bainbridge wrote: > I am assuming here that wait_event_timeout() is supposed to support reentrant > calls.
Not really. It is sort of allowed, provided the inner one will rarely block. And therefore the outer one will mostly work.
> If not, perhaps it should BUG_ON when called with a non-running task > state,
There is a warning in __might_sleep() that catches some of this.
> and the SBS HC / ACPI EC code needs to be fixed to stop doing this.
Yes.
| |